[GridNG] Handle negative indices for out of flow items #27599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 12, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2688802
branch
8 times, most recently
from
42a5b17
to
8fcc3d3
Compare
As it is the case for grid items, out of flow items' indices can have negative values. This change adds support and web tests for the following cases: 1. Negative indices within the grid. 2. Either the start or end line are defined as 'auto' and the corresponding line is at the start or end-most line of the grid. 3. The out of flow item attempts to create new lines with negative indices. 4. Combination of positive and negative indices. 5. Negative indices within an implicitly defined grid. The last case is currently failing because of the different constraints in flow and out of flow items' indices have related to ranges and sets. This will be addressed in a follow up change. Bug: 1045599 Change-Id: Id83db31bcbdb1ee4d5a0313fc109c1288eb12ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688802 Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#856782}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2688802
branch
from
8fcc3d3
to
eec2079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is the case for grid items, out of flow items' indices can have
negative values. This change adds support and web tests for the
following cases:
corresponding line is at the start or end-most line of the grid.
indices.
The last case is currently failing because of the different constraints
in flow and out of flow items' indices have related to ranges and sets.
This will be addressed in a follow up change.
Bug: 1045599
Change-Id: Id83db31bcbdb1ee4d5a0313fc109c1288eb12ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688802
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#856782}